lkml.org 
[lkml]   [2019]   [Apr]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.14 45/53] mlxsw: spectrum: Fix autoneg status in ethtool
    Date
    From: Amit Cohen <amitc@mellanox.com>

    [ Upstream commit 151f0dddbbfe4c35c9c5b64873115aafd436af9d ]

    If link is down and autoneg is set to on/off, the status in ethtool does
    not change.

    The reason is when the link is down the function returns with zero
    before changing autoneg value.

    Move the checking of link state (up/down) to be performed after setting
    autoneg value, in order to be sure that autoneg will change in any case.

    Fixes: 56ade8fe3fe1 ("mlxsw: spectrum: Add initial support for Spectrum ASIC")
    Signed-off-by: Amit Cohen <amitc@mellanox.com>
    Signed-off-by: Ido Schimmel <idosch@mellanox.com>
    Acked-by: Jiri Pirko <jiri@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
    +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c
    @@ -2521,11 +2521,11 @@ mlxsw_sp_port_set_link_ksettings(struct
    if (err)
    return err;

    + mlxsw_sp_port->link.autoneg = autoneg;
    +
    if (!netif_running(dev))
    return 0;

    - mlxsw_sp_port->link.autoneg = autoneg;
    -
    mlxsw_sp_port_admin_status_set(mlxsw_sp_port, false);
    mlxsw_sp_port_admin_status_set(mlxsw_sp_port, true);


    \
     
     \ /
      Last update: 2019-04-30 14:05    [W:4.938 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site