Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 30 Apr 2019 18:58:08 -0700 | Subject | Re: [RFC][PATCH v2] ftrace/x86: Emulate call function while updating in breakpoint handler |
| |
On Tue, Apr 30, 2019 at 6:35 PM Steven Rostedt <rostedt@goodmis.org> wrote: > > > Probably easier to move it from inline asm to ftrace_X.S and use the > lockdep TRACE_ON/OFF macros.
Yeah, that should clean up the percpu stuff too since we have helper macros for it for *.S files anyway.
I only did the asm() in C because it made the "look, something like this" patch simpler to test (and it made it easy to check the generated asm file). Not because it was a good idea ;)
Linus
| |