Messages in this thread | | | Date | Wed, 1 May 2019 00:01:41 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v3 2/7] dt-bindings: mfd: LMU: Add the ramp up/down property |
| |
On Tue 2019-04-30 14:17:25, Dan Murphy wrote: > Document the ramp-up and ramp-down property in the binding. > Removing the "sec" from the property definition as seconds is > implied. > > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > > v3 - No changes added Reviewed-by Rob - https://lore.kernel.org/patchwork/patch/1058759/ > > v2 - Fixed commit message as this was not just a modification but adding documentation > https://lore.kernel.org/patchwork/patch/1054504/ > > .../devicetree/bindings/mfd/ti-lmu.txt | 20 ++++++++++++------- > 1 file changed, 13 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mfd/ti-lmu.txt b/Documentation/devicetree/bindings/mfd/ti-lmu.txt > index 86ca786d54fc..adae96c79d39 100644 > --- a/Documentation/devicetree/bindings/mfd/ti-lmu.txt > +++ b/Documentation/devicetree/bindings/mfd/ti-lmu.txt > @@ -25,6 +25,12 @@ Required properties: > > Optional property:
"properties".
> - enable-gpios: A GPIO specifier for hardware enable pin. > + - ramp-up-ms: Current ramping from one brightness level to > + the a higher brightness level. > + Range from 2048 us - 117.44 s > + - ramp-down-ms: Current ramping from one brightness level to > + the a lower brightness level. > + Range from 2048 us - 117.44 s
Can you use ramp-up/down-us for consistency? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |