Messages in this thread | | | Date | Tue, 30 Apr 2019 13:24:05 -0700 | From | Jacob Pan <> | Subject | Re: [PATCH v2 06/19] drivers core: Add I/O ASID allocator |
| |
On Thu, 25 Apr 2019 11:41:05 +0100 Jean-Philippe Brucker <jean-philippe.brucker@arm.com> wrote:
> On 25/04/2019 11:17, Auger Eric wrote: > >> +/** > >> + * ioasid_alloc - Allocate an IOASID > >> + * @set: the IOASID set > >> + * @min: the minimum ID (inclusive) > >> + * @max: the maximum ID (exclusive) > >> + * @private: data private to the caller > >> + * > >> + * Allocate an ID between @min and @max (or %0 and %INT_MAX). > >> Return the > > I would remove "(or %0 and %INT_MAX)". > > Agreed, those where the default values of idr, but the xarray doesn't > define a default max value. By the way, I do think squashing patches 6 > and 7 would be better (keeping my SOB but you can change the author). > I will squash 6 and 7 in v3. I will just add my SOB but keep the author if that is OK.
| |