lkml.org 
[lkml]   [2019]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] platform/chrome: cros_ec_spi: Transfer messages at high priority
On Wed, Apr 03, 2019 at 11:17:27AM -0700, Doug Anderson wrote:
> Hi,
>
> On Wed, Apr 3, 2019 at 11:14 AM Matthias Kaehlcke <mka@chromium.org> wrote:
> > Each transfer has it's own work struct (allocated on the stack), hence
> > a) does not occur. b) is still true, but shouldn't be a problem on
> > its own.
>
> Actually, it could be much worse _because_ it's on the stack. The
> worker could write something back to the work after the work has been
> de-allocated. That's bad.

Sure, I said "not a problem on its own."
~~~~~~~~~~

The worker is owned by this driver and supposedly we know what we are
doing. Changing a member in the struct after calling complete() would
likely be a bug anyway (though not necessarily a fatal one).

\
 
 \ /
  Last update: 2019-04-03 20:30    [W:0.060 / U:0.156 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site