Messages in this thread | | | Date | Wed, 3 Apr 2019 18:08:18 +0100 | From | Will Deacon <> | Subject | Re: [PATCH] arm64: vdso: fix and clean-up Makefile |
| |
On Thu, Apr 04, 2019 at 02:04:23AM +0900, Masahiro Yamada wrote: > On Wed, Apr 3, 2019 at 9:45 PM Will Deacon <will.deacon@arm.com> wrote: > > On Wed, Apr 03, 2019 at 05:48:22PM +0900, Masahiro Yamada wrote: > > > - $(call if_changed,...) must have FORCE as a prerequisite > > > > > > - vdso.lds is a generated file, so it should be prefixed with > > > $(obj)/ instead of $(src)/. > > > > Hmm, this sounds quite alarming! How come out of tree builds seem to work > > ok without this patch? > > No, I do not mean like that. > This is just cosmetic (at least for now). > Kbuild conventionally use both $(obj) and $(src), but > they are the same in most places. > If you see the top of scripts/Makefile.build, > $(src) is the same as $(obj).
Ah thanks, that makes much more sense. I'll queue this up for 5.2.
Will
| |