Messages in this thread | | | Date | Wed, 3 Apr 2019 12:25:47 -0400 | From | Sasha Levin <> | Subject | Re: [PATCH AUTOSEL 5.0 107/262] ASoC: qcom: Fix of-node refcount unbalance in apq8016_sbc_parse_of() |
| |
On Wed, Mar 27, 2019 at 07:31:15PM +0000, Mark Brown wrote: >On Wed, Mar 27, 2019 at 01:59:22PM -0400, Sasha Levin wrote: >> From: Takashi Iwai <tiwai@suse.de> >> >> [ Upstream commit 8d1667200850f8753c0265fa4bd25c9a6e5f94ce ] >> >> The apq8016 driver leaves the of-node refcount at aborting from the >> loop of for_each_child_of_node() in the error path. Not only the >> iterator node of for_each_child_of_node(), the children nodes referred >> from it for codec and cpu have to be properly unreferenced. > >Given that the device tree is entirely static on all platforms using FDT >I'm not convinced that it is sensible to backport any of the fixes for >references not being dropped that are more than one liners, >realistically nothing is ever going to notice the extra references but >there are things that will notice if we underflow references so there's >some risk we could break things somehow. Seems like it's all risk for >zero benefit.
Fair enough, I'll drop it. Thanks!
-- Thanks, Sasha
| |