lkml.org 
[lkml]   [2019]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices


Στις Τετ, 3 Απρ, 2019 at 10:55 ΠΜ, ο/η Jose Abreu
<jose.abreu@synopsys.com> έγραψε:
> From: Leonidas P. Papadakos <papadakospan@gmail.com>
> Date: Tue, Apr 02, 2019 at 23:48:16
>
>> I can confirm that snps,no-pbl-x8, currently set by uboot for the
>> fdt
>> basically fixes the tx-checksumming issue.
>> I get 700~800 Mbps myself but that might come down to the setup.
>> You could say it affects performance slightly, as I saw in a
>> previous
>> email.
>>
>> Without the setting The rate consistently drops to 0.
>> ethtool reports tx-checksumming is on in both cases
>>
>> Pretty cool!
>> Does that give you guys an idea on how to tackle it "officially"?
>>
>>
>>
>
> Thank you all for testing !
>
> It's been on my todo list to cook up a patch that limits PBL
> according to
> FIFO size but I didn't manage to have the time yet so for now it would
> be better if you fix it by submitting the DT bindings changes.
>
> Thanks,
> Jose Miguel Abreu

If snps,no-pbl-x8 does indeed have a performace hit, should the
workaround be to
a) turn tx checksumming off or
b) snps,no-pbl-x8 set?

I'll test to see the difference


\
 
 \ /
  Last update: 2019-04-03 17:36    [W:0.052 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site