Messages in this thread | | | From | Kees Cook <> | Date | Wed, 3 Apr 2019 08:28:16 -0700 | Subject | Re: [PATCH v3.1] selftests: Clean up module testing shell script |
| |
On Tue, Apr 2, 2019 at 5:24 PM Tobin C. Harding <me@tobin.cc> wrote: > > On Tue, Apr 02, 2019 at 03:26:10PM -0700, Kees Cook wrote: > > This adjusts kselftest_module.sh to take an option "args" argument for > > modprobe arguments, removes bash-isms (since some system's /bin/sh may > > not be bash), and refactors the lib/ scripts into a shorter calling > > convention. > > > > Signed-off-by: Kees Cook <keescook@chromium.org> > > --- > > This is my suggested clean-up for the module testing script for the > > strscpy_pad() series... > > You are seriously at risk of being the most awesome code reviewer on > LKML. Beer is on me next time I see you.
And slowest! ;)
> I will roll this into a v4 for the strscpy_pad() set. Would you like a > Co-developed-by tag or just a mention in the commit log?
I'm happy either way. I really just tweaked it; maybe commit log?
-- Kees Cook
| |