Messages in this thread | | | Subject | Re: [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init() | From | Markus Elfring <> | Date | Wed, 3 Apr 2019 16:23:54 +0200 |
| |
> @@ -146,6 +146,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy) > > cpu = of_get_cpu_node(policy->cpu, NULL); > > + of_node_put(cpu); > if (!cpu) > goto out;
Can the statement “return -ENODEV” be nicer as exception handling in the if branch of this source code place? https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cpufreq/pasemi-cpufreq.c?id=bf97b82f37c6d90e16de001d0659644c57fa490d#n137
Regards, Markus
| |