Messages in this thread | | | Subject | Re: [PATCH v4 2/4] ocxl: read_pasid never returns an error, so make it void | From | Frederic Barrat <> | Date | Wed, 3 Apr 2019 16:20:17 +0200 |
| |
Le 25/03/2019 à 06:34, Alastair D'Silva a écrit : > From: Alastair D'Silva <alastair@d-silva.org> > > No need for a return value in read_pasid as it only returns 0. > > Signed-off-by: Alastair D'Silva <alastair@d-silva.org> > Reviewed-by: Greg Kurz <groug@kaod.org> > ---
Acked-by: Frederic Barrat <fbarrat@linux.ibm.com>
> drivers/misc/ocxl/config.c | 9 ++------- > 1 file changed, 2 insertions(+), 7 deletions(-) > > diff --git a/drivers/misc/ocxl/config.c b/drivers/misc/ocxl/config.c > index 8f2c5d8bd2ee..4dc11897237d 100644 > --- a/drivers/misc/ocxl/config.c > +++ b/drivers/misc/ocxl/config.c > @@ -68,7 +68,7 @@ static int find_dvsec_afu_ctrl(struct pci_dev *dev, u8 afu_idx) > return 0; > } > > -static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) > +static void read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) > { > u16 val; > int pos; > @@ -89,7 +89,6 @@ static int read_pasid(struct pci_dev *dev, struct ocxl_fn_config *fn) > out: > dev_dbg(&dev->dev, "PASID capability:\n"); > dev_dbg(&dev->dev, " Max PASID log = %d\n", fn->max_pasid_log); > - return 0; > } > > static int read_dvsec_tl(struct pci_dev *dev, struct ocxl_fn_config *fn) > @@ -205,11 +204,7 @@ int ocxl_config_read_function(struct pci_dev *dev, struct ocxl_fn_config *fn) > { > int rc; > > - rc = read_pasid(dev, fn); > - if (rc) { > - dev_err(&dev->dev, "Invalid PASID configuration: %d\n", rc); > - return -ENODEV; > - } > + read_pasid(dev, fn); > > rc = read_dvsec_tl(dev, fn); > if (rc) { >
| |