lkml.org 
[lkml]   [2019]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv1] fpga: mgr: add FPGA configuration log
Hi Richard,

On Tue, Apr 02, 2019 at 05:25:43PM -0500, richard.gong@linux.intel.com wrote:
> From: Richard Gong <richard.gong@intel.com>
>
> Add a log for user to know FPGA configuration is successful
>
> Signed-off-by: Richard Gong <richard.gong@intel.com>
> ---
> drivers/fpga/fpga-mgr.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c
> index c386681..559e046 100644
> --- a/drivers/fpga/fpga-mgr.c
> +++ b/drivers/fpga/fpga-mgr.c
> @@ -151,6 +151,7 @@ static int fpga_mgr_write_complete(struct fpga_manager *mgr,
> }
> mgr->state = FPGA_MGR_STATE_OPERATING;
>
> + dev_info(&mgr->dev, "Successfully programming FPGA\n");

That info is available in FPGA manager's sysfs status entry, if at all
I'd make this a dev_dbg().

From my end I don't see how we need this really.

Thanks,
Moritz

\
 
 \ /
  Last update: 2019-04-03 16:21    [W:0.065 / U:0.988 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site