lkml.org 
[lkml]   [2019]   [Apr]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] sparc: vdso: add FORCE to the build rule of %.so
$ grep -r 'call if_changed,' -B

shows a few more FWIW:

drivers/scsi/Makefile
drivers/gpu/drm/radeon/Makefile
arch/c6x/boot/Makefile
arch/arm64/kernel/vdso/Makefile
arch/x86/entry/vdso/Makefile
arch/x86/entry/syscalls/Makefile
arch/powerpc/platforms/cell/spufs/Makefile
arch/powerpc/kernel/syscalls/Makefile
arch/alpha/kernel/syscalls/Makefile
arch/sparc/boot/Makefile
arch/sparc/kernel/syscalls/Makefile
arch/mips/kernel/syscalls/Makefile
arch/h8300/boot/Makefile
arch/nios2/boot/Makefile
arch/ia64/kernel/syscalls/Makefile
arch/microblaze/boot/dts/Makefile
arch/microblaze/kernel/syscalls/Makefile
arch/csky/boot/Makefile
arch/xtensa/kernel/syscalls/Makefile
arch/sh/boot/Makefile
arch/sh/kernel/syscalls/Makefile
arch/parisc/boot/compressed/Makefile
arch/parisc/kernel/syscalls/Makefile
arch/m68k/kernel/syscalls/Makefile


On Wed, Apr 3, 2019 at 3:32 PM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> $(call if_changed,...) must have FORCE as a prerequisite.

According to Documentation/kbuild/makefiles.txt#L1064:
```
Note: It is a typical mistake to forget the FORCE prerequisite.
```

Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>

>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/sparc/vdso/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/sparc/vdso/Makefile b/arch/sparc/vdso/Makefile
> index 74e97f7..83c4b46 100644
> --- a/arch/sparc/vdso/Makefile
> +++ b/arch/sparc/vdso/Makefile
> @@ -68,7 +68,7 @@ CFLAGS_REMOVE_vdso-note.o = -pg
> CFLAGS_REMOVE_vclock_gettime.o = -pg
>
> $(obj)/%.so: OBJCOPYFLAGS := -S
> -$(obj)/%.so: $(obj)/%.so.dbg
> +$(obj)/%.so: $(obj)/%.so.dbg FORCE
> $(call if_changed,objcopy)
>
> CPPFLAGS_vdso32.lds = $(CPPFLAGS_vdso.lds)
> --
> 2.7.4
>


--
Thanks,
~Nick Desaulniers

\
 
 \ /
  Last update: 2019-04-03 12:36    [W:0.194 / U:0.256 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site