Messages in this thread | | | Subject | Re: [PATCH net-next 04/12] net: hns3: return 0 and print warning when hit duplicate MAC | From | tanhuazhong <> | Date | Wed, 3 Apr 2019 17:52:34 +0800 |
| |
On 2019/4/3 17:15, Sergei Shtylyov wrote: > On 03.04.2019 6:07, Huazhong Tan wrote: > >> From: Peng Li <lipeng321@huawei.com> >> >> When set 2 same MAC to different function of one port, IMP >> will return error as the later one may modify the origin one. >> This will cause bond fail for 2 VFs of one port. >> >> Driver just print warning and return 0 with this patch, so >> if set same MAC address, it will return 0 but do not really >> configure to HW. > > "To" not needed here. >
ok, thanks.
>> Signed-off-by: Peng Li <lipeng321@huawei.com> >> Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com> >> --- >> drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c >> b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c >> index e742a05..d45789e 100644 >> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c >> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c >> @@ -5962,8 +5962,11 @@ int hclge_add_uc_addr_common(struct hclge_vport >> *vport, >> } >> /* check if we just hit the duplicate */ >> - if (!ret) >> - ret = -EINVAL; >> + if (!ret) { >> + dev_warn(&hdev->pdev->dev, "VF %d mac(%pM) has been existed\n", > > Maybe just "exists"? The grammar is certainly wrong as is. :-) > >> + vport->vport_id, addr); >> + return 0; >> + } >> dev_err(&hdev->pdev->dev, >> "PF failed to add unicast entry(%pM) in the MAC table\n", > > MBR, Sergei >
ok, thanks.
> . >
| |