Messages in this thread | | | Subject | Re: [PATCH] drm/msm/a6xx: Fix build with !CONFIG_DEBUG_FS | From | Mukesh Ojha <> | Date | Wed, 3 Apr 2019 14:28:50 +0530 |
| |
On 4/3/2019 12:18 PM, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > When building CONFIG_DEBUG_FS is not set > gcc warn this: > > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c: In function a6xx_show: > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:1124:2: error: implicit declaration of function adreno_show; did you mean adreno_dump? [-Werror=implicit-function-declaration] > adreno_show(gpu, state, p); > ^~~~~~~~~~~ > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: 1707add81551 ("drm/msm/a6xx: Add a6xx gpu state") > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers, -Mukesh
> --- > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c > index e686331..d327eb5 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c > @@ -1121,7 +1121,9 @@ void a6xx_show(struct msm_gpu *gpu, struct msm_gpu_state *state, > if (IS_ERR_OR_NULL(state)) > return; > > +#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP) > adreno_show(gpu, state, p); > +#endif > > drm_puts(p, "registers:\n"); > for (i = 0; i < a6xx_state->nr_registers; i++) {
| |