lkml.org 
[lkml]   [2019]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/3] x86: Move DEBUG_TLBFLUSH option.
From
Date
On 4/29/19 1:06 PM, Ingo Molnar wrote:
>
> * Atish Patra <atish.patra@wdc.com> wrote:
>
>> CONFIG_DEBUG_TLBFLUSH was added in 'commit 3df3212f9722 ("x86/tlb: add
>> tlb_flushall_shift knob into debugfs")' to support tlb_flushall_shift
>> knob. The knob was removed in 'commit e9f4e0a9fe27 ("x86/mm: Rip out
>> complicated, out-of-date, buggy TLB flushing")'. However, the debug
>> option was never removed from Kconfig. It was reused in commit
>> '9824cf9753ec ("mm: vmstats: tlb flush counters")' but the commit text
>> was never updated accordingly.
>
> Please, when you mention several commits, put them into new lines to make
> it readable, i.e.:
>
> 3df3212f9722 ("x86/tlb: add tlb_flushall_shift knob into debugfs")
>
> etc.
>
Done.

>> Update the Kconfig option description as per its current usage.
>>
>> Take this opprtunity to make this kconfig option a common option as it
>> touches the common vmstat code. Introduce another arch specific config
>> HAVE_ARCH_DEBUG_TLBFLUSH that can be selected to enable this config.
>
> "opprtunity"?
>
>> +config HAVE_ARCH_DEBUG_TLBFLUSH
>> + bool
>> + depends on DEBUG_KERNEL
>> +
>> +config DEBUG_TLBFLUSH
>> + bool "Save tlb flush statstics to vmstat"
>> + depends on HAVE_ARCH_DEBUG_TLBFLUSH
>> + help
>> +
>> + Add tlbflush statstics to vmstat. It is really helpful understand tlbflush
>> + performance and behavior. It should be enabled only for debugging purpose
>> + by individual architectures explicitly by selecting HAVE_ARCH_DEBUG_TLBFLUSH.
>
> "statstics"??
>
> Please put a spell checker into your workflow or read what you are
> writing ...
>

Apologies for the typos. Fixed them.

Regards,
Atish
> Thanks,
>
> Ingo
>

\
 
 \ /
  Last update: 2019-04-29 23:31    [W:0.078 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site