Messages in this thread | | | Date | Mon, 29 Apr 2019 21:03:48 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH 14/26] iommu/dma: Refactor iommu_dma_free |
| |
On Mon, Apr 29, 2019 at 02:59:43PM +0100, Robin Murphy wrote: > Hmm, I do still prefer my original flow with the dma_common_free_remap() > call right out of the way at the end rather than being a special case in > the middle of all the page-freeing (which is the kind of existing > complexity I was trying to eliminate). I guess you've done this to avoid > having "if (!dma_release_from_contiguous(...))..." twice like I ended up > with, which is fair enough I suppose - once we manage to solve the new > dma_{alloc,free}_contiguous() interface that may tip the balance so I can > always revisit this then.
Ok, I'll try to accomodate that with a minor rework.
| |