Messages in this thread | | | Subject | Re: [PATCH 22/41] drivers: tty: serial: cpm_uart: fix logging calls | From | "Enrico Weigelt, metux IT consult" <> | Date | Mon, 29 Apr 2019 18:20:31 +0200 |
| |
On 29.04.19 17:59, Christophe Leroy wrote:
> If we want to do something useful, wouldn't it make more sense to > introduce the use of dev_err() in order to identify the faulting device > in the message ?
Well, I could get the struct device* pointer via pinfo.port->dev, but I wasn't entirely sure that it's always defined before these functions could be called.
Shall I change it to dev_*() ?
--mtx
-- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
| |