Messages in this thread | | | From | Sven Van Asbroeck <> | Date | Mon, 29 Apr 2019 10:01:37 -0400 | Subject | Re: [PATCH V3] staging: fieldbus: anybus-s: consolidate wait_for_completion_timeout return handling |
| |
On Mon, Apr 29, 2019 at 2:11 AM Nicholas Mc Guire <hofrat@osadl.org> wrote: > > wait_for_completion_timeout() returns unsigned long (0 on timeout or > remaining jiffies) not int - so this type error allows for a > theoretically int overflow - though not in this case where TIMEOUT is > only HZ*2). To fix this type inconsistency the completion is wrapped > into the if() rather than introducing an additional unsigned long > variable. > > Along with fixing this type inconsistency the fall-through if is > consolidated to a single if-block. > > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org> > ---
Queued to https://gitlab.com/TheSven73/linux branch: fieldbus-dev-testing, with my Reviewed-by tag, and the following fix-ups applied: - tweaked commit subject and message slightly (less is more) - removed spurious newline
Thank you Nicholas, I really appreciate it ! Sven
| |