lkml.org 
[lkml]   [2019]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] net_sched: force endianness annotation
From
Date
On 29/04/2019 11:44, Nicholas Mc Guire wrote:
> be16_to_cpu((__force __be16)val) should be a NOP on big-endian as well
Yes.  But it's semiotically wrong to call be16_to_cpu() on a cpu-endian
 value; if the existing behaviour is desired, it ought to be implemented
 differently.
> The problem with using swab16 is that it is impating the binary significantly
> so I'm not sure if the change is really side-effect free
It's not; it changes the behaviour.  That's why I brought up the question
 of the intended behaviour — it's unclear whether the current (no-op on BE)
 behaviour is correct or whether it's a bug in the original code.
Better to leave the sparse error in place — drawing future developers'
 attention to something being possibly wrong here — than to mask it with a
 synthetic 'fix' which we don't even know if it's correct or not.

> but I just am unsure if
> - val = be16_to_cpu(val);
> + val = swab16(val);
> is actually equivalent.
If you're not sure about such things, maybe you shouldn't be touching
 endianness-related code.  swab is *not* a no-op, either on BE or LE.

-Ed

\
 
 \ /
  Last update: 2019-04-29 13:12    [W:0.054 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site