lkml.org 
[lkml]   [2019]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] mtd: onenand/samsung: Unify resource order for controller variants
    Hi Paweł,

    Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com> wrote on Fri, 26 Apr 2019
    18:42:20 +0200:

    > From: Tomasz Figa <tomasz.figa@gmail.com>
    >
    > Before this patch, the order of memory resources requested by the driver
    > was controller base as first and OneNAND chip base as second for
    > S3C64xx/S5PC100 variant and the opposite for S5PC110/S5PV210 variant.
    >
    > To make this more consistent, this patch swaps the order of resources
    > for the latter and updates platform code accordingly. As a nice side
    > effect there is a slight reduction in line count of probe function.
    >
    > Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
    > Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@gmail.com>

    Thanks for the patch but it looks like you also are renaming fields in
    the main onenand structure. Maybe it is worth doing it in a preliminary
    patch.

    Thanks,
    Miquèl

    \
     
     \ /
      Last update: 2019-04-29 10:17    [W:3.106 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site