Messages in this thread | | | Subject | Re: [PATCH] driver core: Fix use-after-free and double free on glue directory | From | Benjamin Herrenschmidt <> | Date | Sun, 28 Apr 2019 13:10:19 +0300 |
| |
On Thu, 2019-04-25 at 23:44 +0800, Muchun Song wrote: > I agree with you that the looking up of the glue dir and creation of its child > should be protected by the same lock of gdp_mutex. So, do you agree with > the fix of the following code snippet?
The basic idea yes, the whole bool *locked is horrid though. Wouldn't it work to have a get_device_parent_locked that always returns with the mutex held, or just move the mutex to the caller or something simpler like this ?
Ben.
| |