Messages in this thread | | | Date | Fri, 26 Apr 2019 13:02:04 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH -next] lib/vsprintf: Make function pointer_string static |
| |
On Sat, 27 Apr 2019 00:46:30 +0800 Yue Haibing <yuehaibing@huawei.com> wrote:
> From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warning: > > lib/vsprintf.c:673:6: warning: > symbol 'pointer_string' was not declared. Should it be static? > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > lib/vsprintf.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/vsprintf.c b/lib/vsprintf.c > index 1f367f3..7b0a614 100644 > --- a/lib/vsprintf.c > +++ b/lib/vsprintf.c > @@ -670,8 +670,9 @@ char *string(char *buf, char *end, const char *s, > return string_nocheck(buf, end, s, spec); > } > > -char *pointer_string(char *buf, char *end, const void *ptr, > - struct printf_spec spec) > +static char *pointer_string(char *buf, char *end,
Looks like commit "vsprintf: Do not check address of well-known strings" removed the: "static noinline_for_stack"
Does pointer_string() need that still?
Petr?
-- Steve
> + const void *ptr, > + struct printf_spec spec) > { > spec.base = 16; > spec.flags |= SMALL;
| |