Messages in this thread | | | Date | Fri, 26 Apr 2019 08:05:45 -0700 | From | Jacob Pan <> | Subject | Re: [PATCH v2 09/19] iommu/vt-d: Enlightened PASID allocation |
| |
On Fri, 26 Apr 2019 09:24:29 +0200 Auger Eric <eric.auger@redhat.com> wrote:
> > Agreed > >>> +#define VCMD_VRSP_RESULE(e) (((e) >> 8) & > >>> 0xfffff) > >> nit: s/RESULE/RSLT? > > yes. Also the mask bits should be 8 to 63 > > s/0xfffff/GENMASK_ULL(63, 8))/ > Well the macro definition looks correct as 63:28 is RsvdZ
you are right, I misread the spec.
Thanks,
Jacob
| |