lkml.org 
[lkml]   [2019]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] net: ath: fix missing checks for bmi reads and writes
Date
Kangjie Lu <kjlu@umn.edu> writes:

> ath10k_bmi_write32 and ath10k_bmi_read32 can fail. The fix
> checks their statuses to avoid potential undefined behaviors.
>
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>

[...]

> @@ -2500,8 +2515,15 @@ int ath10k_core_start(struct ath10k *ar, enum ath10k_firmware_mode mode,
> if (status)
> goto err;
>
> - if (ar->hif.bus == ATH10K_BUS_SDIO)
> - ath10k_init_sdio(ar);
> + if (ar->hif.bus == ATH10K_BUS_SDIO) {
> + status = ath10k_init_sdio(ar);
> + if (status) {
> + ath10k_err(ar,
> + "could not init HTC (%d)\n",
> + status);

I'll fix the warning message as well, we are not initialisating HTC
here.

--
Kalle Valo

\
 
 \ /
  Last update: 2019-04-26 13:53    [W:0.054 / U:0.820 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site