Messages in this thread | | | Subject | Re: [PATCH] net: wireless: fix missing checks for ioremap | From | Kalle Valo <> | Date | Fri, 26 Apr 2019 11:48:24 +0000 (UTC) |
| |
Kangjie Lu <kjlu@umn.edu> wrote:
> ioremap could fail and returns NULL. The fix actively checks > its return value and handles potential failures. > > Signed-off-by: Kangjie Lu <kjlu@umn.edu>
The prefix should be "ray_cs: ":
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_title_is_wrong
Also I don't see the point of setting the ret variable as it's ignored in the failed label:
failed: ray_release(link); return -ENODEV;
Patch set to Changes Requested.
-- https://patchwork.kernel.org/patch/10846851/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
| |