lkml.org 
[lkml]   [2019]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] power: supply: bq27xxx_battery: Notify also about status changes
On Fri, 26 Apr 2019 at 11:32, Pali Rohár <pali.rohar@gmail.com> wrote:
>
> On Friday 26 April 2019 11:26:48 Krzysztof Kozlowski wrote:
> > User-space might be interested in receiving uevents when the charging
> > starts/stops or if conditions of battery changes (e.g.
> > over-temperature). Notify about changes in battery also when the flags
> > change, not only SoC.
>
> This looks like a good idea.
>
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > drivers/power/supply/bq27xxx_battery.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
> > index 29b3a4056865..cb9306160c14 100644
> > --- a/drivers/power/supply/bq27xxx_battery.c
> > +++ b/drivers/power/supply/bq27xxx_battery.c
> > @@ -1612,7 +1612,8 @@ void bq27xxx_battery_update(struct bq27xxx_device_info *di)
> > di->charge_design_full = bq27xxx_battery_read_dcap(di);
> > }
> >
> > - if (di->cache.capacity != cache.capacity)
> > + if ((di->cache.capacity != cache.capacity) || \
> ^^
> You have there an extra backslash

Indeed, Thanks! Let me send v2.

Best regards,
Krzysztof

\
 
 \ /
  Last update: 2019-04-26 11:58    [W:2.321 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site