Messages in this thread | | | Subject | Re: [RFC PATCH v3 net-next 06/11] dt-bindings: net: ti: add new cpsw switch driver bindings | From | Grygorii Strashko <> | Date | Fri, 26 Apr 2019 10:50:25 +0300 |
| |
On 26.04.19 01:40, Andrew Lunn wrote: >> +Required Sub-nodes: >> +- ports : contains CPSW external ports descriptions >> + Required properties: >> + - #address-cells : Must be 1 >> + - #size-cells : Must be 0 >> + - reg : CPSW port number. Should be 1 or 2 >> + - phys : phandle on phy-gmii-sel PHY (see phy/ti-phy-gmii-sel.txt) >> + - phy-mode : operation mode of the PHY interface [1] >> + - phy-handle : phandle to a PHY on an MDIO bus [1] > > >> + cpsw_port1: port@1 { >> + reg = <1>; >> + ti,label = "port1"; >> + /* Filled in by U-Boot */ >> + mac-address = [ 00 00 00 00 00 00 ]; >> + phys = <&phy_gmii_sel 1>; > > Hi Grygorii > > phy-mode and phy-handle are required, but missing from your example. > > Otherwise, this looks like a reasonable binding.
Yea. they configured in board files - will add.
Thanks.
-- Best regards, grygorii
| |