Messages in this thread | | | Subject | Re: [PATCH] vfio-pci/nvlink2: Fix potential VMA leak | From | Alexey Kardashevskiy <> | Date | Fri, 26 Apr 2019 17:50:22 +1000 |
| |
On 20/04/2019 01:37, Greg Kurz wrote: > If vfio_pci_register_dev_region() fails then we should rollback > previous changes, ie. unmap the ATSD registers. > > Signed-off-by: Greg Kurz <groug@kaod.org> > --- > drivers/vfio/pci/vfio_pci_nvlink2.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfio_pci_nvlink2.c > index 32f695ffe128..50fe3c4f7feb 100644 > --- a/drivers/vfio/pci/vfio_pci_nvlink2.c > +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c > @@ -472,6 +472,8 @@ int vfio_pci_ibm_npu2_init(struct vfio_pci_device *vdev) > return 0; > > free_exit: > + if (data->base) > + memunmap(data->base); > kfree(data); > > return ret; >
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
-- Alexey
| |