lkml.org 
[lkml]   [2019]   [Apr]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.0 42/79] ASoC: cs35l35: Disable regulators on driver removal
    Date
    From: Charles Keepax <ckeepax@opensource.cirrus.com>

    [ Upstream commit 47c4cc08cb5b34e93ab337b924c5ede77ca3c936 ]

    The chips main power supplies VA and VP are enabled during probe but
    then never disabled, this will cause warnings from the regulator
    framework on driver removal. Fix this by adding a remove callback and
    disabling the supplies, whilst doing so follow best practice and put the
    chip back into reset as well.

    Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/cs35l35.c | 11 +++++++++++
    1 file changed, 11 insertions(+)

    diff --git a/sound/soc/codecs/cs35l35.c b/sound/soc/codecs/cs35l35.c
    index 9f4a59871cee..c71696146c5e 100644
    --- a/sound/soc/codecs/cs35l35.c
    +++ b/sound/soc/codecs/cs35l35.c
    @@ -1635,6 +1635,16 @@ err:
    return ret;
    }

    +static int cs35l35_i2c_remove(struct i2c_client *i2c_client)
    +{
    + struct cs35l35_private *cs35l35 = i2c_get_clientdata(i2c_client);
    +
    + regulator_bulk_disable(cs35l35->num_supplies, cs35l35->supplies);
    + gpiod_set_value_cansleep(cs35l35->reset_gpio, 0);
    +
    + return 0;
    +}
    +
    static const struct of_device_id cs35l35_of_match[] = {
    {.compatible = "cirrus,cs35l35"},
    {},
    @@ -1655,6 +1665,7 @@ static struct i2c_driver cs35l35_i2c_driver = {
    },
    .id_table = cs35l35_id,
    .probe = cs35l35_i2c_probe,
    + .remove = cs35l35_i2c_remove,
    };

    module_i2c_driver(cs35l35_i2c_driver);
    --
    2.19.1
    \
     
     \ /
      Last update: 2019-04-27 03:55    [W:4.187 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site