Messages in this thread | | | From | Doug Anderson <> | Date | Fri, 26 Apr 2019 15:26:48 -0700 | Subject | Re: [PATCH v6 1/3] tracing: kdb: The skip_lines parameter should have been skip_entries |
| |
Hi,
On Tue, Mar 19, 2019 at 10:12 AM Douglas Anderson <dianders@chromium.org> wrote: > > The things skipped by kdb's "ftdump" command when you pass it a > parameter has always been entries, not lines. The difference usually > doesn't matter but when the trace buffer has multi-line entries (like > a stack dump) it can matter. > > Let's fix this both in the help text for ftdump and also in the local > variable names. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > Acked-by: Daniel Thompson <daniel.thompson@linaro.org> > --- > > Changes in v6: None > Changes in v5: > - Add Daniel Thompson Ack. > > Changes in v4: > - skip_lines => skip_entries new for v4. > > Changes in v3: None > > kernel/trace/trace_kdb.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-)
Steven: do you know if/when you plan to take this series? There's no crazy hurry and if you like I can sent a calendar alert to remember to ping you after 5.1 is released so you can land this in a "for 5.3" queue. Just let me know. :-)
-Doug
| |