Messages in this thread Patch in this message | | | From | Kees Cook <> | Date | Thu, 25 Apr 2019 10:11:20 -0700 | Subject | Re: [PATCH v2 0/8] selftests: Move test output to diagnostic lines |
| |
On Thu, Apr 25, 2019 at 10:05 AM Kees Cook <keescook@chromium.org> wrote: > WARNING: Misplaced SPDX-License-Identifier tag - use line 1 instead > #37: FILE: tools/testing/selftests/kselftest/runner.sh:2: > # SPDX-License-Identifier: GPL-2.0 > > This is a shell script. It can't be on line 1: > > $ head -n3 tools/testing/selftests/kselftest/runner.sh > #!/bin/sh > # SPDX-License-Identifier: GPL-2.0 > # > > That looks like a bug in checkpatch not resetting the expected line or > something.
It doesn't like patch 3 and doesn't notice that diff offset starts at line 2:
diff --git a/tools/testing/selftests/kselftest/runner.sh b/tools/testing/selftests/kselftest/runner.sh index e1117d703887..f12b0a631273 100644 --- a/tools/testing/selftests/kselftest/runner.sh +++ b/tools/testing/selftests/kselftest/runner.sh @@ -2,17 +2,20 @@ # SPDX-License-Identifier: GPL-2.0 # # Runs a set of tests in a given subdirectory. +export KSFT_TAP_LEVEL=1
Joe, looks like the problem is here:
if ($realline == $checklicenseline) { realline == 2, checklicenseline == 1 so this is skipped, including the "#!/" check to move checklicenseline to 2. then: if ($realline != $checklicenseline && $rawline =~ /\bSPDX-License-Identifier:/ && realline == 2, checklicenseline == 1 throws warning.
Seems like checklicenseline should be unconditionally set to 2 for ".sh" files? I don't see a way to fix this for just missing the #!/ line from a context diff, though...
-- Kees Cook
| |