Messages in this thread | | | Date | Thu, 25 Apr 2019 15:43:21 +0900 | From | Sergey Senozhatsky <> | Subject | Re: [RFC][PATCH 1/2] printk: lock console_sem before we unregister boot consoles |
| |
On (04/25/19 12:52), Sergey Senozhatsky wrote: > > Could we remove it in this patch? It touches it indirectly anyway. > > Sure we can. > > We also can take extra care of pr_info("%sconsole [%s%d] enabled\n". > Right now we do > > ... > console_unlock(); > console_sysfs_notify(); > > pr_info("%sconsole [%s%d] enabled\n",.... > > > But we can simply move that pr_info() a bit up: > > pr_info("%sconsole [%s%d] enabled\n", > console_unlock(); > console_sysfs_notify(); > > > So the message will be printed on all consoles.
---
Petr, Steven, would you prefer to have it as two separate patches - one removes the comment; the other one moves pr_info("console enabled") - or as one patch? It's sort of trivial enough to be in just one patch, but I also can submit it as separate changes.
-ss
| |