Messages in this thread | | | Date | Fri, 26 Apr 2019 06:28:53 +1000 | From | Stephen Rothwell <> | Subject | Re: [PATCH] lib/siphash.c: mark expected switch fall-throughs |
| |
Hi Greg,
On Thu, 25 Apr 2019 19:46:15 +0200 Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Tue, Apr 16, 2019 at 06:03:58PM +0900, Jason A. Donenfeld wrote: > > On Tue, Apr 16, 2019 at 4:27 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we are expecting to fall through. > > > > > > This patch aims to suppress up to 18 missing-break-in-switch false > > > positives on some architectures. > > > > > > Cc: Jason A. Donenfeld <Jason@zx2c4.com> > > > Cc: Gustavo A. R. Silva <gustavo@embeddedor.com> > > > Cc: Kees Cook <keescook@chromium.org> > > > Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> > > > > Looks good to me, thanks for this. > > > > Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com> > > > > Perhaps Greg can take it through his tree? > > Me? Ok, fine, I'll go queue it up...
Excellent, thanks.
-- Cheers, Stephen Rothwell [unhandled content-type:application/pgp-signature] | |