Messages in this thread | | | Subject | Re: [PATCH net-next] net: socket: Fix missing break in switch statement | From | "Gustavo A. R. Silva" <> | Date | Wed, 24 Apr 2019 14:47:46 -0500 |
| |
Arnd,
On 4/24/19 1:45 PM, Arnd Bergmann wrote: > On Wed, Apr 24, 2019 at 5:33 PM Gustavo A. R. Silva > <gustavo@embeddedor.com> wrote: >> >> Add missing break statement in order to prevent the code from falling >> through to cases SIOCGSTAMP_NEW and SIOCGSTAMPNS_NEW. >> >> This bug was found thanks to the ongoing efforts to enable >> -Wimplicit-fallthrough. >> >> Fixes: 0768e17073dc ("net: socket: implement 64-bit timestamps") >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Just for clarification: Dan didn't report this to me. I found this bug while working on the last fall-through warnings in net.
> Acked-by: Arnd Bergmann <arnd@arndb.de> > > I had just prepared the same patch after Dan told me about the issue today, > but you managed to submit it first. > > Thanks for the fix! >
Glad to help. :)
Thanks -- Gustavo
| |