lkml.org 
[lkml]   [2019]   [Apr]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 001/115] bonding: fix event handling for stacked bonds
    Date
    From: Sabrina Dubroca <sd@queasysnail.net>

    [ Upstream commit 92480b3977fd3884649d404cbbaf839b70035699 ]

    When a bond is enslaved to another bond, bond_netdev_event() only
    handles the event as if the bond is a master, and skips treating the
    bond as a slave.

    This leads to a refcount leak on the slave, since we don't remove the
    adjacency to its master and the master holds a reference on the slave.

    Reproducer:
    ip link add bondL type bond
    ip link add bondU type bond
    ip link set bondL master bondU
    ip link del bondL

    No "Fixes:" tag, this code is older than git history.

    Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/bonding/bond_main.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    --- a/drivers/net/bonding/bond_main.c
    +++ b/drivers/net/bonding/bond_main.c
    @@ -3214,8 +3214,12 @@ static int bond_netdev_event(struct noti
    return NOTIFY_DONE;

    if (event_dev->flags & IFF_MASTER) {
    + int ret;
    +
    netdev_dbg(event_dev, "IFF_MASTER\n");
    - return bond_master_netdev_event(event, event_dev);
    + ret = bond_master_netdev_event(event, event_dev);
    + if (ret != NOTIFY_DONE)
    + return ret;
    }

    if (event_dev->flags & IFF_SLAVE) {

    \
     
     \ /
      Last update: 2019-04-24 19:45    [W:6.121 / U:0.388 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site