Messages in this thread | | | Date | Wed, 24 Apr 2019 10:51:54 -0500 | From | Josh Poimboeuf <> | Subject | Re: [PATCH 2/3] stacktrace: Remove superfluous WARN_ONCE() from save_stack_trace_tsk_reliable() |
| |
On Wed, Apr 24, 2019 at 10:55:49AM +0200, Petr Mladek wrote: > WARN_ONCE() in the generic save_stack_trace_tsk_reliable() is superfluous. > The only current user klp_check_stack() writes its own warning when > -ENOSYS is returned. > > Signed-off-by: Petr Mladek <pmladek@suse.com> > --- > kernel/stacktrace.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/kernel/stacktrace.c b/kernel/stacktrace.c > index f8edee9c792d..83ac0ac5ffd9 100644 > --- a/kernel/stacktrace.c > +++ b/kernel/stacktrace.c > @@ -74,6 +74,5 @@ __weak int > save_stack_trace_tsk_reliable(struct task_struct *tsk, > struct stack_trace *trace) > { > - WARN_ONCE(1, KERN_INFO "save_stack_tsk_reliable() not implemented yet.\n"); > return -ENOSYS; > } > -- > 2.16.4 >
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
-- Josh
| |