Messages in this thread | | | Subject | Re: [PATCH] powerpc/pseries: Use correct event modifier in rtas_parse_epow_errlog() | From | Russell Currey <> | Date | Wed, 24 Apr 2019 11:29:47 +1000 |
| |
On Tue, 2019-04-23 at 22:35 +0800, Yue Haibing wrote: > From: YueHaibing <yuehaibing@huawei.com> > > rtas_parse_epow_errlog() should pass 'modifier' to > handle_system_shutdown, because event modifier only use > bottom 4 bits. > > Fixes: 55fc0c561742 ("powerpc/pseries: Parse and handle EPOW > interrupts") > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Hello,
This fails to compile.
arch/powerpc/platforms/pseries/ras.c: In function 'rtas_parse_epow_errlog': arch/powerpc/platforms/pseries/ras.c:288:26: error: 'event_modifier' undeclared (first use in this function); did you mean 'modifier'? handle_system_shutdown(event_modifier); ^~~~~~~~~~~~~~ modifier
So yes, I assume you meant "modifier" instead of "event_modifier" as mentioned in your commit message. Did you compile this before sending?
(found by snowpatch)
- Russell
| |