lkml.org 
[lkml]   [2019]   [Apr]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 2/2] regmap: soundwire: fix Kconfig select/depend issue
On 19-04-19, 14:46, Pierre-Louis Bossart wrote:
> The mechanism should be
>
> config CODEC_XYX_SDW
> depends on SOUNDWIRE
> select REGMAP_SOUNDWIRE
>
> config REGMAP_SOUNDWIRE
> select SOUNDWIRE_BUS
>
> SOUNDWIRE_BUS can be independently selected by the SOC driver. The SOC
> driver should not know or care about REGMAP_SOUNDWIRE.

lgtm, Mark can I have ypu ack so that I can carry the series thru
soundwire tree

Thanks

> Fixes: 7c22ce6e2184 ('03fc8746f7915b5a391d8227f7e1')
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> drivers/base/regmap/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/base/regmap/Kconfig b/drivers/base/regmap/Kconfig
> index 6ad5ef48b61e..c12e3f1fb110 100644
> --- a/drivers/base/regmap/Kconfig
> +++ b/drivers/base/regmap/Kconfig
> @@ -44,7 +44,7 @@ config REGMAP_IRQ
>
> config REGMAP_SOUNDWIRE
> tristate
> - depends on SOUNDWIRE_BUS
> + select SOUNDWIRE_BUS
>
> config REGMAP_SCCB
> tristate
> --
> 2.17.1

--
~Vinod

\
 
 \ /
  Last update: 2019-04-22 08:02    [W:0.069 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site