Messages in this thread | | | From | Gregory CLEMENT <> | Subject | Re: [PATCH 2/3] ARM: mvebu: drop return from void function | Date | Sun, 21 Apr 2019 19:23:11 +0200 |
| |
Hi Nicholas,
> The return statement is unnecessary here - so drop it. > > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Applied on mvebu/arm
Thanks,
Gregory
> --- > > Problem reported by checkpatch > > WARNING: void function return statements are not generally useful > #141: FILE: arch/arm/mach-mvebu/board-v7.c:141: > + return; > +} > > Patch was compile-tested: mvebu_v7_defconfig (implies MACH_MVEBU_ANY=y) > (with some unrelated sparse warnings about missing syscalls) > > Patch is against 5.1-rc4 (localversion-next is 20190412) > > arch/arm/mach-mvebu/board-v7.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm/mach-mvebu/board-v7.c b/arch/arm/mach-mvebu/board-v7.c > index 37f8cb6..28fd256 100644 > --- a/arch/arm/mach-mvebu/board-v7.c > +++ b/arch/arm/mach-mvebu/board-v7.c > @@ -137,7 +137,6 @@ static void __init i2c_quirk(void) > > of_update_property(np, new_compat); > } > - return; > } > > static void __init mvebu_dt_init(void) > -- > 2.1.4 >
-- Gregory Clement, Bootlin Embedded Linux and Kernel engineering http://bootlin.com
| |