Messages in this thread | | | Subject | Re: [PATCH 1/2] dt-bindings: iio: counter: Add Milbeaut Updown Counter | From | Kanematsu, Shinji/兼松 伸次 <> | Date | Tue, 2 Apr 2019 15:26:07 +0900 |
| |
Hi Rob,
Thank you for your review.
On 2019/03/31 15:42, Rob Herring wrote: > On Tue, Mar 26, 2019 at 03:33:09PM +0900, Shinji Kanematsu wrote: >> Add documentation for Milbeaut Updown Counter device >> quadrature encoder and counter binding. >> >> Signed-off-by: Shinji Kanematsu <kanematsu.shinji@socionext.com> >> --- >> .../bindings/iio/counter/milbeaut-updown_cnt.txt | 22 ++++++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/iio/counter/milbeaut-updown_cnt.txt >> >> diff --git a/Documentation/devicetree/bindings/iio/counter/milbeaut-updown_cnt.txt b/Documentation/devicetree/bindings/iio/counter/milbeaut-updown_cnt.txt >> new file mode 100644 >> index 0000000..6771567 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/iio/counter/milbeaut-updown_cnt.txt >> @@ -0,0 +1,22 @@ >> +SOCIONEXT Milbeaut Updown counter >> + >> +Required properties: >> +- compatible: Must be "socionext,milbeaut-updown-counter". >> +- reg: Offset and length of the device's register set. >> +- clocks: Phandle to the clock used by the Updown counter module. >> +- clock-names: Must be "mux". >> +- interrupts: SPI number of the device's set. >> +- cms_type: connected_device >> + 1: updown button (updown counter mode) >> + 2: rotary encoder (phase difference counter mode) > > We should have a common property for describing what's attached. > IIRC, just had a similar binding recently. >
OK, I search the similar binding.
Thank you, Kanematsu
>> + >> +Example: >> + >> + updown0: updown@1e002000 { >> + compatible = "socionext,milbeaut-updown-counter"; >> + reg = <0x1e002000 0x20>; >> + clocks = <&clk 4>; >> + clock-names = "mux"; >> + interrupts = <0 104 0x4>; >> + cms_type = <1>; >> + }; >> -- >> 1.9.1 >> >
| |