lkml.org 
[lkml]   [2019]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1] driver core: platform: Propagate error from insert_resource()
On Tue, Apr 2, 2019 at 5:59 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> Since insert_resource() might return an error we don't need
> to shadow its error code and would safely propagate to the user.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/base/platform.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> index dab0a5abc391..f93f192891d1 100644
> --- a/drivers/base/platform.c
> +++ b/drivers/base/platform.c
> @@ -438,9 +438,8 @@ int platform_device_add(struct platform_device *pdev)
> p = &ioport_resource;
> }
>
> - if (p && insert_resource(p, r)) {
> + if (p && (ret = insert_resource(p, r))) {

I would put the assignment here.

> dev_err(&pdev->dev, "failed to claim resource %d: %pR\n", i, r);
> - ret = -EBUSY;
> goto failed;
> }
> }
> --
> 2.20.1
>

\
 
 \ /
  Last update: 2019-04-02 18:04    [W:0.069 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site