Messages in this thread Patch in this message | | | Date | Tue, 2 Apr 2019 07:19:25 +0100 | From | Lee Jones <> | Subject | Re: [PATCH 1/4] Add support for SUNIX Multi-I/O board |
| |
On Tue, 19 Mar 2019, Morris Ku wrote:
> Add Kconfig and Makefile entry. > > Signed-off-by: Morris Ku <saumah@gmail.com> > --- > mfd/Kconfig | 5 +++++ > mfd/Makefile | 2 ++ > 2 files changed, 7 insertions(+)
Can you send this set again please. There are some basic issues with it, which would make reviewing difficult.
Please use `git format-patch` and `git send-email` to create and submit your patches. Use the following flags; --annotate, --compose and --thread to ensure the patches are sent a) pinned to each other so they do not become spread throughout people's inboxes and b) a cover letter is provided which should contain a summary of what you are trying to achieve.
The diff should be based from the root directory, not 'drivers', such that the diff should read "drivers/mfd/*".
> diff --git a/mfd/Kconfig b/mfd/Kconfig > index 76f9909c..efbb3ef1 100644 > --- a/mfd/Kconfig > +++ b/mfd/Kconfig > @@ -1916,5 +1916,10 @@ config RAVE_SP_CORE > Select this to get support for the Supervisory Processor > device found on several devices in RAVE line of hardware. > > +config SUNIX > + tristate "SUNIX Multi-I/O Board Driver" > + help > + Support for SUNIX Multi-I/O controller. > + > endmenu > endif > diff --git a/mfd/Makefile b/mfd/Makefile > index 12980a4a..b70f44de 100644 > --- a/mfd/Makefile > +++ b/mfd/Makefile > @@ -241,4 +241,6 @@ obj-$(CONFIG_MFD_MXS_LRADC) += mxs-lradc.o > obj-$(CONFIG_MFD_SC27XX_PMIC) += sprd-sc27xx-spi.o > obj-$(CONFIG_RAVE_SP_CORE) += rave-sp.o > obj-$(CONFIG_MFD_ROHM_BD718XX) += rohm-bd718x7.o > +obj-$(CONFIG_SUNIX) += sunix/ > + >
-- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
| |