Messages in this thread | | | Date | Tue, 2 Apr 2019 11:50:17 +0200 | From | Antoine Tenart <> | Subject | Re: [PATCH net-next v3 1/2] net: phy: marvell10g: implement suspend/resume callbacks |
| |
Hi Heiner,
Sorry for the late answer.
On Tue, Mar 26, 2019 at 07:43:27PM +0100, Heiner Kallweit wrote: > On 26.03.2019 15:53, Antoine Tenart wrote: > > This patch adds the suspend/resume callbacks for Marvell 10G PHYs. The > > three PCS (base-t, base-r and 1000base-x) are set in low power (the PCS > > are powered down) when the PHY isn't used. > > > At least for the 3310 the datasheet mentions that via VEND2.f001.11 > the port can be powered down completely. As this would simplify the code, > did you test this?
I just tested this, and it does simplify the code a lot. Thanks for pointing out this bit.
I'll update and make a v2.
Antoine
-- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
| |