Messages in this thread | | | Date | Tue, 2 Apr 2019 09:54:02 +0200 | From | Daniel Vetter <> | Subject | Re: [PATCH 2/3] drm/bochs: add missing drm_atomic_helper_shutdown() call. |
| |
On Mon, Apr 01, 2019 at 04:03:05PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> > --- > drivers/gpu/drm/bochs/bochs_kms.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bochs/bochs_kms.c b/drivers/gpu/drm/bochs/bochs_kms.c > index 9e7cd6b34106..93cb27f93d39 100644 > --- a/drivers/gpu/drm/bochs/bochs_kms.c > +++ b/drivers/gpu/drm/bochs/bochs_kms.c > @@ -293,6 +293,7 @@ int bochs_kms_init(struct bochs_device *bochs) > void bochs_kms_fini(struct bochs_device *bochs) > { > if (bochs->mode_config_initialized) {
This mode_config_initialized is hilarious. I think (from looking at git history and all) this started in radeon, back when kms was an add-on, and radeon.ko still supported ums. Then it was dutifully copypasted into cirrus, bochs, mgag200, hisilicon and also amdgpu.
Afaict none of these drivers need this (but I didn't bother to review amdgpu and radeon fully). Would be nice little cleanup to follow up with.
Anyway, on your 3 patches here:
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> + drm_atomic_helper_shutdown(bochs->dev); > drm_mode_config_cleanup(bochs->dev); > bochs->mode_config_initialized = false; > } > -- > 2.18.1 >
-- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
| |