Messages in this thread | | | Subject | Re: [PATCH] kdb: Get rid of broken attempt to print CCVERSION in kdb summary | From | Joe Perches <> | Date | Fri, 19 Apr 2019 20:57:05 -0700 |
| |
On Fri, 2019-04-19 at 13:58 -0700, Andrew Morton wrote: > On Fri, 19 Apr 2019 04:14:27 -0700 Joe Perches <joe@perches.com> wrote: > > On Fri, 2019-04-19 at 12:28 +0900, Masahiro Yamada wrote: > > > Can you detect redundant Cc: by checkpatch? [] > > I'm not sure why it's useful or necessary. [] > The issue here is redundant Cc: lines in the changelog.
CC: entries have very little actual value in a changelog anyway.
> > --- a/scripts/checkpatch.pl [] > > @@ -2688,6 +2688,19 @@ sub process { > > $signatures{$sig_nospace} = 1; > > } > > > > +# Check for a cc: line with another signature -by: by the same author > > + if ($sig_nospace =~ /^cc:/) { > > + my $sig_email = substr($sig_nospace, 3); > > + foreach my $sig (sort keys %signatures) { > > + next if ($sig =~ /^cc:/); > > + $sig =~ s/^[^:]+://; > > + if ($sig eq $sig_email) { > > + WARN("BAD_SIGN_OFF", > > + "Unnecessary CC: as there is another signature with the same name/email address\n" . $herecurr); > > + } > > + } > > + } > > + > > # Check Co-developed-by: immediately followed by Signed-off-by: with same name and email > > if ($sign_off =~ /^co-developed-by:$/i) { > > if ($email eq $author) { > > Thanks. But my checkpatch.pl is different from yours. > > q:/usr/src/25> grep "immediately followed by" scripts/checkpatch.pl > q:/usr/src/25>
I almost always write patches against -next
$ git grep "immediately followed by" next-20190418 -- scripts/checkpatch.pl next-20190418:scripts/checkpatch.pl:# Check Co-developed-by: immediately followed by Signed-off-by: with same name and email next-20190418:scripts/checkpatch.pl: "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline); next-20190418:scripts/checkpatch.pl: "Co-developed-by: must be immediately followed by Signed-off-by:\n" . "$here\n" . $rawline . "\n" .$rawlines[$linenr]);
You seem to be missing
commit 6c5d24eef7be7adfcb608f2852ab69b58935133b Author: Sean Christopherson <sean.j.christopherson@intel.com> Date: Fri Mar 22 14:11:37 2019 -0700
checkpatch: Warn on improper usage of Co-developed-by
The purpose of Co-developed-by: is to give attribution to authors who aren't already attributed by the From: tag, i.e. who aren't the nominal patch author. Because Co-developed-by: is essentially a variation of From:, it must be accompanied by a Signed-off-by: of the associated co-author. To ease the burden of determining whether or not co-authors have signed off, Co-developed-by and Signed-off-by: must be explicitly paired, i.e. on consecutive lines for a given co-author.
Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com> Signed-off-by: Jonathan Corbet <corbet@lwn.net>
| |