Messages in this thread Patch in this message | | | Date | Fri, 19 Apr 2019 08:55:03 -0700 | From | tip-bot for Andi Kleen <> | Subject | [tip:x86/timers] x86/timer: Don't inline __const_udelay() |
| |
Commit-ID: 81423c37415fe45057d64196ae0ce8e17a9c7148 Gitweb: https://git.kernel.org/tip/81423c37415fe45057d64196ae0ce8e17a9c7148 Author: Andi Kleen <ak@linux.intel.com> AuthorDate: Fri, 29 Mar 2019 17:47:38 -0700 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Fri, 19 Apr 2019 17:49:47 +0200
x86/timer: Don't inline __const_udelay()
LTO will happily inline __const_udelay() everywhere it is used. Forcing it noinline saves ~44k text in a LTO build.
13999560 1740864 1499136 17239560 1070e08 vmlinux-with-udelay-inline 13954764 1736768 1499136 17190668 1064f0c vmlinux-wo-udelay-inline
Even without LTO this function should never be inlined.
Signed-off-by: Andi Kleen <ak@linux.intel.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lkml.kernel.org/r/20190330004743.29541-4-andi@firstfloor.org
--- arch/x86/lib/delay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/lib/delay.c b/arch/x86/lib/delay.c index f5b7f1b3b6d7..b7375dc6898f 100644 --- a/arch/x86/lib/delay.c +++ b/arch/x86/lib/delay.c @@ -162,7 +162,7 @@ void __delay(unsigned long loops) } EXPORT_SYMBOL(__delay); -void __const_udelay(unsigned long xloops) +noinline void __const_udelay(unsigned long xloops) { unsigned long lpj = this_cpu_read(cpu_info.loops_per_jiffy) ? : loops_per_jiffy; int d0;
| |