Messages in this thread | | | Date | Mon, 15 Apr 2019 18:09:17 +0200 | From | Daniel Vetter <> | Subject | Re: [PATCH v2 3/3] DRM: Add KMS driver for the Ingenic JZ47xx SoCs |
| |
On Sat, Mar 16, 2019 at 10:59:44PM +0100, Sam Ravnborg wrote: > > + ret = drm_fbdev_generic_setup(drm, 16); > > + if (ret) { > > + dev_err(dev, "Failed to init fbdev\n"); > > + goto err_devclk_disable; > > + } > fbdev is usually considered an optionl feature that do not prevent > the display driver from loading. > Consider what to do in the error case.
Drive-through comment: Totally ok to require this, failing here usually means you have a driver bug somewhere. fbdev is optional as in Kconfig optional, but people who enable it generally need it. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch
| |