lkml.org 
[lkml]   [2019]   [Apr]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH v2 03/36] coresight: tpiu: Cleanup power management
    Date
    Drop the power only when we have successfully probed. Otherwise
    leave it to the amba probe to do the rest.

    Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
    Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
    ---
    drivers/hwtracing/coresight/coresight-tpiu.c | 8 ++++++--
    1 file changed, 6 insertions(+), 2 deletions(-)

    diff --git a/drivers/hwtracing/coresight/coresight-tpiu.c b/drivers/hwtracing/coresight/coresight-tpiu.c
    index b2f72a1..4977467 100644
    --- a/drivers/hwtracing/coresight/coresight-tpiu.c
    +++ b/drivers/hwtracing/coresight/coresight-tpiu.c
    @@ -153,7 +153,6 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id)
    /* Disable tpiu to support older devices */
    tpiu_disable_hw(drvdata);

    - pm_runtime_put(&adev->dev);

    desc.type = CORESIGHT_DEV_TYPE_SINK;
    desc.subtype.sink_subtype = CORESIGHT_DEV_SUBTYPE_SINK_PORT;
    @@ -162,7 +161,12 @@ static int tpiu_probe(struct amba_device *adev, const struct amba_id *id)
    desc.dev = dev;
    drvdata->csdev = coresight_register(&desc);

    - return PTR_ERR_OR_ZERO(drvdata->csdev);
    + if (!IS_ERR(drvdata->csdev)) {
    + pm_runtime_put(&adev->dev);
    + return 0;
    + }
    +
    + return PTR_ERR(drvdata->csdev);
    }

    #ifdef CONFIG_PM
    --
    2.7.4
    \
     
     \ /
      Last update: 2019-04-15 18:09    [W:3.246 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site