Messages in this thread | | | From | "Alastair D'Silva" <> | Subject | RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags | Date | Mon, 15 Apr 2019 21:12:15 +1000 |
| |
> -----Original Message----- > From: David Laight <David.Laight@ACULAB.COM> > Sent: Monday, 15 April 2019 9:04 PM > To: 'Alastair D'Silva' <alastair@d-silva.org>; 'Petr Mladek' > <pmladek@suse.com> > Cc: 'Alastair D'Silva' <alastair@au1.ibm.com>; 'Jani Nikula' > <jani.nikula@linux.intel.com>; 'Joonas Lahtinen' > <joonas.lahtinen@linux.intel.com>; 'Rodrigo Vivi' <rodrigo.vivi@intel.com>; > 'David Airlie' <airlied@linux.ie>; 'Daniel Vetter' <daniel@ffwll.ch>; 'Karsten > Keil' <isdn@linux-pingi.de>; 'Jassi Brar' <jassisinghbrar@gmail.com>; 'Tom > Lendacky' <thomas.lendacky@amd.com>; 'David S. Miller' > <davem@davemloft.net>; 'Jose Abreu' <Jose.Abreu@synopsys.com>; 'Kalle > Valo' <kvalo@codeaurora.org>; 'Stanislaw Gruszka' <sgruszka@redhat.com>; > 'Benson Leung' <bleung@chromium.org>; 'Enric Balletbo i Serra' > <enric.balletbo@collabora.com>; 'James E.J. Bottomley' > <jejb@linux.ibm.com>; 'Martin K. Petersen' <martin.petersen@oracle.com>; > 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>; 'Alexander Viro' > <viro@zeniv.linux.org.uk>; 'Sergey Senozhatsky' > <sergey.senozhatsky@gmail.com>; 'Steven Rostedt' > <rostedt@goodmis.org>; 'Andrew Morton' <akpm@linux-foundation.org>; > intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org; linux- > kernel@vger.kernel.org; netdev@vger.kernel.org; > ath10k@lists.infradead.org; linux-wireless@vger.kernel.org; linux- > scsi@vger.kernel.org; linux-fbdev@vger.kernel.org; > devel@driverdev.osuosl.org; linux-fsdevel@vger.kernel.org > Subject: RE: [PATCH 3/4] lib/hexdump.c: Replace ascii bool in > hex_dump_to_buffer with flags > > From: Alastair D'Silva > > Sent: 15 April 2019 11:45 > ... > > > Although I think you'd want a 'no hex' flag to suppress the hex. > > > > > > Probably more useful flags are ones to suppress the address column. > > > > This is already supported by the prefix_type parameter - are you > > proposing that we eliminate the parameter & combine it with flags? > > I was looking at the flags on one of my hexdump() functions... > > > > I've also used flags to enable (or disable) suppression of multiple > > > lines of zeros of constant bytes. > > > In that case you may want hexdump to return the flags for the next > > > call when a large buffer is being dumped in fragments. > > > > I'm afraid I don't quite follow here, hex_dump_to_buffer doesn't alter > > the flags, so the caller already knows it. > > If you are suppressing lines of zeros and dumping a buffer in several blocks > then subsequent calls need to know that the last line of the previous call was > suppressed zeros - and carry on with the same suppressed block.
Why wouldn't you do this with a single call to print_hex_dump? (that is where the repeated lines are suppressed)
That will already take chunks of the buffer until the whole thing is output, in what situation do you see a caller chunking the access themselves?
-- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: alastair@d-silva.org blog: http://alastair.d-silva.org Twitter: @EvilDeece
| |